Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: wait tiflash replicas ready && fix unstable test (#46301) #46342

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46301

What problem does this PR solve?

Issue Number: close #46302

Problem Summary:

  1. restore wait tiflash ready need handle partition tables
  2. tiflash refresh ticker need 2 seconds to trigger. so make the test sleep 3 seconds.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@7241e78). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46342   +/-   ##
================================================
  Coverage               ?   73.6586%           
================================================
  Files                  ?       1084           
  Lines                  ?     348099           
  Branches               ?          0           
================================================
  Hits                   ?     256405           
  Misses                 ?      75233           
  Partials               ?      16461           

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 23, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 23, 2023
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@3pointer
Copy link
Contributor

/run-intergration-br-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-23 05:53:25.903365647 +0000 UTC m=+1301570.452381631: ☑️ agreed by BornChanger.
  • 2023-08-23 07:07:03.262701264 +0000 UTC m=+1305987.811717251: ☑️ agreed by YuJuncen.

@YuJuncen
Copy link
Contributor

/hold for integration tests.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@3pointer
Copy link
Contributor

/run-intergration-br-tests

1 similar comment
@3pointer
Copy link
Contributor

/run-intergration-br-tests

@3pointer
Copy link
Contributor

/run-integration-br-tests

@3pointer
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

@3pointer: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit d7ce2f2 into pingcap:release-6.5 Aug 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants