Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explaintest: Support concurrent execution #46346

Closed

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Aug 23, 2023

What problem does this PR solve?

Issue Number: ref #45961

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from defined2014. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2023
@tiprow
Copy link

tiprow bot commented Aug 23, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 force-pushed the support-concurrent-execution branch from 02ad840 to 81e0983 Compare August 23, 2023 06:28
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3875%. Comparing base (7e476a5) to head (83f7c57).
Report is 4080 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46346        +/-   ##
================================================
+ Coverage   73.3517%   73.3875%   +0.0358%     
================================================
  Files          1284       1288         +4     
  Lines        393256     393523       +267     
================================================
+ Hits         288460     288797       +337     
+ Misses        86433      86343        -90     
- Partials      18363      18383        +20     
Flag Coverage Δ
unit 73.3875% <ø> (+0.0358%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0741% <ø> (+0.0073%) ⬆️
br 52.2684% <ø> (+0.0281%) ⬆️

@Defined2014 Defined2014 force-pushed the support-concurrent-execution branch from 81e0983 to b6c04f4 Compare August 23, 2023 06:52
@Defined2014
Copy link
Contributor Author

Seems running tests in parallel, the execution plan is not very stable, so close this one.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
Copy link

ti-chi-bot bot commented Nov 18, 2024

@Defined2014: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 83f7c57 link true /test build
idc-jenkins-ci-tidb/mysql-test 83f7c57 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 83f7c57 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 83f7c57 link true /test check-dev
pull-mysql-client-test 83f7c57 link true /test pull-mysql-client-test
pull-integration-ddl-test 83f7c57 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/unit-test 83f7c57 link true /test unit-test
pull-br-integration-test 83f7c57 link true /test pull-br-integration-test
pull-lightning-integration-test 83f7c57 link true /test pull-lightning-integration-test
pull-integration-e2e-test 83f7c57 link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Defined2014 Defined2014 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant