Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: estimate real file size by sample on compressed file #46404

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Aug 24, 2023

What problem does this PR solve?

Issue Number: ref #42930

Problem Summary:

What is changed and how it works?

  • estimate real file size by sample on compressed file. it will be used when divide files into engine and calculate rowid.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 24, 2023
@D3Hunter
Copy link
Contributor Author

/ok-to-test

@tiprow
Copy link

tiprow bot commented Aug 24, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #46404 (7e45fdb) into master (c94b9ae) will decrease coverage by 0.6733%.
Report is 1 commits behind head on master.
The diff coverage is 88.8888%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46404        +/-   ##
================================================
- Coverage   73.3709%   72.6976%   -0.6733%     
================================================
  Files          1302       1323        +21     
  Lines        394467     400698      +6231     
================================================
+ Hits         289424     291298      +1874     
- Misses        86645      90943      +4298     
- Partials      18398      18457        +59     
Flag Coverage Δ
integration 25.6202% <0.0000%> (?)
unit 73.3746% <88.8888%> (+0.0037%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0638% <ø> (ø)
br 48.0201% <100.0000%> (-4.3599%) ⬇️

executor/importer/import.go Outdated Show resolved Hide resolved
br/pkg/lightning/mydump/loader.go Outdated Show resolved Hide resolved
@D3Hunter
Copy link
Contributor Author

/hold

race found

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2023
@D3Hunter
Copy link
Contributor Author

@lance6716 see #46430 first, to solve data race

@D3Hunter
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@D3Hunter
Copy link
Contributor Author

@lance6716 @GMHDBJD

@D3Hunter
Copy link
Contributor Author

ping @lance6716

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if some compression types also save the original file size in metadata

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 31, 2023
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-31 02:54:25.173581 +0000 UTC m=+1982029.722596987: ☑️ agreed by lance6716.
  • 2023-09-05 10:42:04.294533839 +0000 UTC m=+2442088.843549826: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit 586b854 into master Sep 5, 2023
17 of 24 checks passed
@ti-chi-bot ti-chi-bot bot deleted the importinto-compress branch September 5, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants