Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explaintest: don't use test database in explaintest #46449

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #45961

Problem Summary: remove use test in explaintest, avoid environmental problems.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 28, 2023
@tiprow
Copy link

tiprow bot commented Aug 28, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #46449 (28538ba) into master (2163271) will decrease coverage by 0.1887%.
Report is 21 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46449        +/-   ##
================================================
- Coverage   73.4346%   73.2460%   -0.1887%     
================================================
  Files          1295       1324        +29     
  Lines        393757     406313     +12556     
================================================
+ Hits         289154     297608      +8454     
- Misses        86235      90277      +4042     
- Partials      18368      18428        +60     
Flag Coverage Δ
integration 26.1833% <ø> (?)
unit 73.9210% <ø> (+0.4863%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.1859% <ø> (+0.1226%) ⬆️
br 48.1809% <ø> (-4.1262%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2023
@Defined2014 Defined2014 changed the title explaintest: use a separate database for each case explaintest: don't use test database in explaintest Aug 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-28 08:49:01.75487609 +0000 UTC m=+1744106.303892074: ☑️ agreed by hawkingrei.
  • 2023-08-30 03:31:38.444589049 +0000 UTC m=+1897862.993605035: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit c59bf90 into pingcap:master Aug 30, 2023
8 of 9 checks passed
@Defined2014 Defined2014 deleted the remove-use-test branch November 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants