-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: share etcd client from domain for autoid allocator #46647
Conversation
Skipping CI for Draft Pull Request. |
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46647 +/- ##
================================================
+ Coverage 71.5384% 72.8309% +1.2924%
================================================
Files 1402 1425 +23
Lines 406159 412790 +6631
================================================
+ Hits 290560 300639 +10079
+ Misses 95775 93251 -2524
+ Partials 19824 18900 -924
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
br part LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, GMHDBJD, lcwangchao, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
/test mysql-test |
@tiancaiamao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #46324
Problem Summary:
The autoid allocate service need a etcd client, we can create one and close it after use.
But every time infoschema reload, we need to create one...
A better solution is to share the etcd client in domain.Domain (also ddl.DDL)
What is changed and how it works?
Refactor the auto id parameter from
kv.Store
toautoid.Requirement
The
autoid.Requirement
now consists of a kv.Store and a clientv3.Client...This change affect quite a lot packages, especially tools packages.
Check List
Tests
This is a code refactor so all the old tests should not be break.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.