Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: make TestUpgradeWithPauseDDL stable #46692

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 5, 2023

What problem does this PR solve?

Issue Number: close #46388

Problem Summary:
The job may be pausing, we only check it uses paused.

What is changed and how it works?

  • Using pausing or paused to check whether the job is pausing.
  • Extract the function of checkDDLJobState from the same two pieces of judgment code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2023
@tiprow
Copy link

tiprow bot commented Sep 5, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the test for the pull request and check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #46692 (7c9ec4f) into master (db570ea) will decrease coverage by 0.6578%.
Report is 17 commits behind head on master.
The diff coverage is 62.7907%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46692        +/-   ##
================================================
- Coverage   73.3586%   72.7009%   -0.6578%     
================================================
  Files          1315       1339        +24     
  Lines        395675     402453      +6778     
================================================
+ Hits         290262     292587      +2325     
- Misses        86932      91346      +4414     
- Partials      18481      18520        +39     
Flag Coverage Δ
integration 25.4020% <11.6279%> (?)
unit 73.3872% <62.7907%> (+0.0285%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9689% <ø> (+0.0108%) ⬆️
br 48.1484% <ø> (-4.2891%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-05 14:20:29.213781624 +0000 UTC m=+2455193.762797608: ☑️ agreed by hawkingrei.
  • 2023-09-06 03:31:08.053072501 +0000 UTC m=+2502632.602088488: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 09a83b8 into pingcap:master Sep 6, 2023
5 of 9 checks passed
@wuhuizuo wuhuizuo mentioned this pull request Sep 11, 2023
23 tasks
@zimulala zimulala deleted the zimuxia/upgrade-test branch March 7, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/test lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestUpgradeWithPauseDDL failed in CI
3 participants