-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics/grafana: revert pr/30311 and fix the 'PD Client CMD Duration' panel #46754
Conversation
Skipping CI for Draft Pull Request. |
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46754 +/- ##
================================================
+ Coverage 73.2873% 75.7155% +2.4282%
================================================
Files 1319 1382 +63
Lines 395898 435839 +39941
================================================
+ Hits 290143 329998 +39855
- Misses 87268 87555 +287
+ Partials 18487 18286 -201
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackysp, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/merge |
@tiancaiamao: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/check-issue-triage-complete |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #30307
Problem Summary:
What is changed and how it works?
Something is wrong, I think I made some mistakes
This time it should be correct.
Check List
Tests
tiup playground
explore & edit & export ...
import again & verify the changes ...
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.