Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics/grafana: revert pr/30311 and fix the 'PD Client CMD Duration' panel #46754

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #30307

Problem Summary:

What is changed and how it works?

Something is wrong, I think I made some mistakes
This time it should be correct.

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

tiup playground
explore & edit & export ...
import again & verify the changes ...

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 7, 2023
@tiancaiamao tiancaiamao marked this pull request as ready for review September 7, 2023 09:59
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2023
@tiprow
Copy link

tiprow bot commented Sep 7, 2023

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao tiancaiamao requested a review from jackysp September 7, 2023 10:00
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #46754 (03f5f5d) into master (670778e) will increase coverage by 2.4282%.
Report is 292 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46754        +/-   ##
================================================
+ Coverage   73.2873%   75.7155%   +2.4282%     
================================================
  Files          1319       1382        +63     
  Lines        395898     435839     +39941     
================================================
+ Hits         290143     329998     +39855     
- Misses        87268      87555       +287     
+ Partials      18487      18286       -201     
Flag Coverage Δ
integration 40.9922% <ø> (?)
unit 76.1841% <ø> (+2.8968%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.4418% <ø> (+0.3973%) ⬆️
parser 88.0107% <ø> (+3.0193%) ⬆️
br 51.6584% <ø> (-0.8050%) ⬇️

@tiancaiamao
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackysp, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 10:07:13.402943385 +0000 UTC m=+2612797.951959371: ☑️ agreed by jackysp.
  • 2023-09-20 03:11:02.201199541 +0000 UTC m=+659828.168787586: ☑️ agreed by tangenta.

@wuhuizuo
Copy link
Contributor

/retest

@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

@tiancaiamao: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Oct 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0648fcf into pingcap:master Oct 10, 2023
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #47504.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 10, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@tiancaiamao tiancaiamao deleted the recover-metrics branch October 10, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana dashboard no data in PD Client -> Start TSO Wait Duration
5 participants