Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: "no leader" should be a retryable error (#46300) #46860

Merged
merged 4 commits into from
Sep 25, 2023
Merged

lightning: "no leader" should be a retryable error (#46300) #46860

merged 4 commits into from
Sep 25, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46300

What problem does this PR solve?

Issue Number: close #45673 #46253

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#46300
65d0ff6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2023
Benjamin2037
Benjamin2037 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 11, 2023
GMHDBJD
GMHDBJD approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 08:46:03.729373067 +0000 UTC m=+258945.653929461: ☑️ agreed by Benjamin2037.
  • 2023-09-11 08:47:16.360131927 +0000 UTC m=+259018.284688322: ☑️ agreed by GMHDBJD.

@Benjamin2037
Copy link
Collaborator

/retest

@lance6716
Copy link
Contributor

/hold

wrong code snippet is cherry-picked

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@lance6716
fix git conflict
a56333b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 19, 2023
@lance6716
add failpoint
90d36e5 
Signed-off-by: lance6716 <lance6716@gmail.com>
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@ae6d59b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46860   +/-   ##
================================================
  Coverage               ?   73.7323%           
================================================
  Files                  ?       1084           
  Lines                  ?     348311           
  Branches               ?          0           
================================================
  Hits                   ?     256818           
  Misses                 ?      75041           
  Partials               ?      16452

@lance6716
address comment
1e34fa9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor

/unhold
/test pull-br-integration-test

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@tiprow
Copy link

tiprow bot commented Sep 19, 2023

@lance6716: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/unhold
/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 25, 2023
@Benjamin2037
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot merged commit e850bf5 into pingcap:release-6.5 Sep 25, 2023
14 checks passed
@Benjamin2037 Benjamin2037 deleted the cherry-pick-46300-to-release-6.5 branch September 25, 2023 13:56
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@ti-chi-bot
lightning: "no leader" should be a retryable error (pingcap#46300) (p…
79400bf 
…ingcap#46860) (pingcap#9)

close pingcap#45673

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees

@Benjamin2037 Benjamin2037

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @Benjamin2037 @lance6716 @GMHDBJD