Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor to make colStatsUsageMap thread-safe #46949

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 13, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: refactor to make colStatsUsageMap thread-safe

What is changed and how it works?

No logical change, just refactor, create a separate structure for colStatsUsage, and hide the lock in it to make it thread-safe.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2023
@tiprow
Copy link

tiprow bot commented Sep 13, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #46949 (8acbed8) into master (c7f5781) will decrease coverage by 0.4113%.
Report is 17 commits behind head on master.
The diff coverage is 80.1932%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46949        +/-   ##
================================================
- Coverage   73.2870%   72.8758%   -0.4113%     
================================================
  Files          1331       1353        +22     
  Lines        397358     407795     +10437     
================================================
+ Hits         291212     297184      +5972     
- Misses        87541      92028      +4487     
+ Partials      18605      18583        -22     
Flag Coverage Δ
integration 28.3929% <14.0096%> (?)
unit 73.5914% <80.1932%> (+0.3043%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0019% <ø> (ø)
br 48.6102% <100.0000%> (-4.3034%) ⬇️

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 10:27:57.814467627 +0000 UTC m=+81243.782055680: ☑️ agreed by hi-rustin.
  • 2023-09-13 10:36:10.076900702 +0000 UTC m=+81736.044488752: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 13, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 13, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 13, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 13, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 14, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 14, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot merged commit a7617f3 into pingcap:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants