Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Implement /upgrade/start and upgrade/finish APIs #47000

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 15, 2023

What problem does this PR solve?

Issue Number: ref: #45885, close #47172

Problem Summary:
Cherry-pick #45887, #46276, #46425, #46494, #46644

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zimulala zimulala added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Sep 15, 2023
@zimulala zimulala requested a review from a team as a code owner September 15, 2023 04:02
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 15, 2023
@tiprow
Copy link

tiprow bot commented Sep 15, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 15, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 15, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@8e47816). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #47000   +/-   ##
================================================
  Coverage               ?   73.8998%           
================================================
  Files                  ?       1205           
  Lines                  ?     381860           
  Branches               ?          0           
================================================
  Hits                   ?     282194           
  Misses                 ?      82136           
  Partials               ?      17530           

@zimulala
Copy link
Contributor Author

PTAL @Benjamin2037 @tangenta

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 19, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 11, 2023
@zimulala
Copy link
Contributor Author

PTAL @tangenta

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-19 03:12:46.539354578 +0000 UTC m=+573532.506942628: ☑️ agreed by Benjamin2037.
  • 2023-10-11 09:19:09.887725959 +0000 UTC m=+1216747.474836105: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit a1ea04c into pingcap:release-7.1 Oct 11, 2023
8 checks passed
@zimulala zimulala deleted the zimuxia/upgrade-api branch October 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants