snapshot_backup: deny executing tidb-lightning import while running snapshot_backup #47001

YuJuncen · 2023-09-15T06:23:13Z

What problem does this PR solve?

Issue Number: ref #46850

Problem Summary:
See the issue.

What is changed and how it works?

A new RPC named "DenyImprotRpcs" has been added to TiKV, which allows us deny importing during backing up.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot · 2023-09-15T06:23:15Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2023-09-15T06:23:35Z

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: hillium <yujuncen@pingcap.com>

…ghtning Signed-off-by: hillium <yujuncen@pingcap.com>

Signed-off-by: hillium <yujuncen@pingcap.com>

br/pkg/task/backup_ebs.go

BornChanger · 2023-09-20T07:35:41Z

br/pkg/task/operator/cmd.go

+	ctx.ReadyL("pause_lightning")
+	ctx.runGrp.Go(func() error {
+		err := denyLightning.Keeper(ctx, ctx.cfg.TTL)
+		if errors.Cause(err) != context.Canceled {


what's the value to record a log entry here?

So we can know what happened to TiKV for troubleshooting.

BornChanger · 2023-09-20T07:45:35Z

/retest

tiprow · 2023-09-20T07:46:05Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YuJuncen · 2023-09-20T09:00:56Z

@BornChanger Well I guess our CI cannot pass as long as we have replaced the kvproto to our own repo... 😢

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-09-22T08:37:03Z

/test all

tiprow · 2023-09-22T08:37:40Z

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YuJuncen · 2023-09-22T08:38:44Z

/ok-to-test

…ghtning Signed-off-by: hillium <yujuncen@pingcap.com>

Signed-off-by: hillium <yujuncen@pingcap.com>

3pointer · 2023-09-27T10:14:40Z

br/pkg/utils/suspend_importing.go

+	GetDenyLightningClient(ctx context.Context, storeID uint64) (SuspendLightningClient, error)
+}
+
+type SuspendLightningClient interface {


SuspendLightningClient is not proper because it's not suspend lightning only. also include br restore. so it's better to be SuspendImportingClient or SuspendIngestClient

Signed-off-by: hillium <yujuncen@pingcap.com>

BornChanger

Again, please refresh the title and pr description. Others lgtm.

BornChanger · 2023-09-27T13:36:06Z

/test tiprow_fast_test

ti-chi-bot · 2023-09-27T13:36:09Z

@BornChanger: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-prisma-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-09-27T13:40:18Z

/ok-to-test

hawkingrei · 2023-09-27T13:40:31Z

/ok-to-test

ti-chi-bot · 2023-09-27T13:43:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [3pointer]
~~br/OWNERS~~ [3pointer,BornChanger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-09-27T13:43:30Z

[LGTM Timeline notifier]

Timeline:

2023-09-27 11:48:56.594595468 +0000 UTC m=+16134.181705613: ☑️ agreed by BornChanger.
2023-09-27 13:43:29.618978961 +0000 UTC m=+23007.206089092: ☑️ agreed by 3pointer.

ti-chi-bot · 2023-09-27T13:56:33Z

In response to a cherrypick label: new pull request created to branch release-6.5: #47341.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2023-09-27T13:57:17Z

In response to a cherrypick label: new pull request created to branch release-7.1: #47342.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

…napshot_backup (#47001) (#47341) ref #46850

…napshot_backup (pingcap#47001) (pingcap#47341) ref pingcap#46850

…napshot_backup (#47001) (#47342) ref #46850

…napshot_backup (pingcap#47001) (pingcap#47341) (pingcap#20) ref pingcap#46850 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

YuJuncen added 2 commits September 14, 2023 11:26

initial vesrion

9255438

Signed-off-by: hillium <yujuncen@pingcap.com>

fix tls config

4ee25c8

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen added 2 commits September 16, 2023 11:20

added some test cases

8eaffd6

Signed-off-by: hillium <yujuncen@pingcap.com>

Merge branch 'master' of https://github.com/pingcap/tidb into deny-li…

c2668b0

…ghtning Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen marked this pull request as ready for review September 19, 2023 06:56

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023

make bazel_prepare

fc4d563

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2023

BornChanger reviewed Sep 20, 2023

View reviewed changes

YuJuncen added 4 commits September 20, 2023 18:06

rename RPC

133a75f

Signed-off-by: hillium <yujuncen@pingcap.com>

fix build and test

4f8cd52

Signed-off-by: hillium <yujuncen@pingcap.com>

make bazel_prepare

836f83e

Signed-off-by: hillium <yujuncen@pingcap.com>

address comments

f3f351c

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 22, 2023

YuJuncen added 2 commits September 25, 2023 18:18

Merge branch 'master' of https://github.com/pingcap/tidb into deny-li…

9ba0178

…ghtning Signed-off-by: hillium <yujuncen@pingcap.com>

back to master

b253365

Signed-off-by: hillium <yujuncen@pingcap.com>

3pointer reviewed Sep 27, 2023

View reviewed changes

YuJuncen added 2 commits September 27, 2023 19:23

address comments

2118fd0

Signed-off-by: hillium <yujuncen@pingcap.com>

make bazel_prepare

74b3754

Signed-off-by: hillium <yujuncen@pingcap.com>

BornChanger approved these changes Sep 27, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 27, 2023

3pointer approved these changes Sep 27, 2023

View reviewed changes

ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2023

ti-chi-bot bot merged commit 32540a4 into pingcap:master Sep 27, 2023

ti-chi-bot mentioned this pull request Sep 27, 2023

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup (#47001) #47341

Merged

4 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 27, 2023

This is an automated cherry-pick of pingcap#47001

ae07c91

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Sep 27, 2023

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup (#47001) #47342

Merged

4 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 27, 2023

This is an automated cherry-pick of pingcap#47001

8642a0e

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

BornChanger mentioned this pull request Sep 27, 2023

ebs br: EBS snapshot restore could panic during lightning ingest SST phase pingcap/tidb-operator#5289

Closed

ti-chi-bot bot pushed a commit that referenced this pull request Sep 28, 2023

snapshot_backup: deny executing tidb-lightning import while running s…

f961aa5

…napshot_backup (#47001) (#47341) ref #46850

BornChanger pushed a commit to BornChanger/tidb that referenced this pull request Sep 28, 2023

snapshot_backup: deny executing tidb-lightning import while running s…

bd058cf

…napshot_backup (pingcap#47001) (pingcap#47341) ref pingcap#46850

YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Sep 29, 2023

snapshot_backup: deny executing tidb-lightning import while running s…

1d9e8f5

…napshot_backup (pingcap#47001) (pingcap#47341) ref pingcap#46850

YuJuncen mentioned this pull request Oct 10, 2023

snap_backup: make snapshot backup exit once importing task detected #46854

Closed

4 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023

snapshot_backup: deny executing tidb-lightning import while running s…

a56af1b

…napshot_backup (#47001) (#47342) ref #46850

BornChanger mentioned this pull request Nov 29, 2023

EBS BR support to multiple k8s cluster TiDB pingcap/tidb-operator#5003

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup #47001

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup #47001

YuJuncen commented Sep 15, 2023

ti-chi-bot bot commented Sep 15, 2023

tiprow bot commented Sep 15, 2023

BornChanger Sep 20, 2023

YuJuncen Sep 22, 2023

BornChanger commented Sep 20, 2023

tiprow bot commented Sep 20, 2023

YuJuncen commented Sep 20, 2023

YuJuncen commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

YuJuncen commented Sep 22, 2023

3pointer Sep 27, 2023

BornChanger left a comment

BornChanger commented Sep 27, 2023

ti-chi-bot bot commented Sep 27, 2023

BornChanger commented Sep 27, 2023

hawkingrei commented Sep 27, 2023

ti-chi-bot bot commented Sep 27, 2023

ti-chi-bot bot commented Sep 27, 2023

ti-chi-bot commented Sep 27, 2023

ti-chi-bot commented Sep 27, 2023

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup #47001

snapshot_backup: deny executing tidb-lightning import while running snapshot_backup #47001

Conversation

YuJuncen commented Sep 15, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Sep 15, 2023

tiprow bot commented Sep 15, 2023

BornChanger Sep 20, 2023

Choose a reason for hiding this comment

YuJuncen Sep 22, 2023

Choose a reason for hiding this comment

BornChanger commented Sep 20, 2023

tiprow bot commented Sep 20, 2023

YuJuncen commented Sep 20, 2023

YuJuncen commented Sep 22, 2023

tiprow bot commented Sep 22, 2023

YuJuncen commented Sep 22, 2023

3pointer Sep 27, 2023

Choose a reason for hiding this comment

BornChanger left a comment

Choose a reason for hiding this comment

BornChanger commented Sep 27, 2023

ti-chi-bot bot commented Sep 27, 2023

BornChanger commented Sep 27, 2023

hawkingrei commented Sep 27, 2023

ti-chi-bot bot commented Sep 27, 2023

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

ti-chi-bot commented Sep 27, 2023

ti-chi-bot commented Sep 27, 2023