-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: add comments and change isIndex
to bool
#47062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 self-check
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47062 +/- ##
================================================
- Coverage 73.0205% 72.6744% -0.3461%
================================================
Files 1336 1357 +21
Lines 398462 404757 +6295
================================================
+ Hits 290959 294155 +3196
- Misses 88697 91897 +3200
+ Partials 18806 18705 -101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
statistics: rename
77bb2f7
to
c11971d
Compare
What problem does this PR solve?
Issue Number: None
Problem Summary:
What is changed and how it works?
isIndex
to boolCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.