Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add comments and change isIndex to bool #47062

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: None

Problem Summary:

What is changed and how it works?

  • Added more comments.
  • Change isIndex to bool

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • Only update comment

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2023
@Rustin170506 Rustin170506 added the skip-issue-check Indicates that a PR no need to check linked issue. label Sep 18, 2023
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 self-check

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #47062 (1a70aac) into master (51f6bb9) will decrease coverage by 0.3461%.
The diff coverage is 81.5789%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47062        +/-   ##
================================================
- Coverage   73.0205%   72.6744%   -0.3461%     
================================================
  Files          1336       1357        +21     
  Lines        398462     404757      +6295     
================================================
+ Hits         290959     294155      +3196     
- Misses        88697      91897      +3200     
+ Partials      18806      18705       -101     
Flag Coverage Δ
integration 30.4981% <81.5789%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9620% <ø> (ø)
br 48.6578% <ø> (-4.3491%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 09:08:43.246979321 +0000 UTC m=+508489.214567372: ☑️ agreed by hawkingrei.
  • 2023-09-18 09:14:41.716665712 +0000 UTC m=+508847.684253762: ☑️ agreed by winoros.

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4bd39b5 into pingcap:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants