Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use the session pool to execute SQLs in statshandler #47065

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 18, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: use the session pool to execute SQLs in statshandler

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2023
@tiprow
Copy link

tiprow bot commented Sep 18, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #47065 (a6bca96) into master (4cc6c65) will decrease coverage by 0.1962%.
Report is 5 commits behind head on master.
The diff coverage is 51.2345%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47065        +/-   ##
================================================
- Coverage   73.0345%   72.8383%   -0.1962%     
================================================
  Files          1336       1357        +21     
  Lines        398257     405333      +7076     
================================================
+ Hits         290865     295238      +4373     
- Misses        88616      91472      +2856     
+ Partials      18776      18623       -153     
Flag Coverage Δ
integration 30.6918% <17.2839%> (?)
unit 73.1837% <51.2345%> (+0.1492%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9728% <ø> (+0.0107%) ⬆️
br 48.7369% <ø> (-4.2900%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-19 01:47:39.226548737 +0000 UTC m=+568425.194136783: ☑️ agreed by hawkingrei.
  • 2023-09-19 02:13:44.03917717 +0000 UTC m=+569990.006765221: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 19, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 19, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 19, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 19, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 19, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 19, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit fdff1e6 into pingcap:master Sep 19, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants