Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: cleanup sorted files, writer memory quota, and test #47092

Merged
merged 16 commits into from
Sep 20, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #46704

Problem Summary:

  • cleanup sorted files when task done
  • calculate writer memory quota based on index count
  • test

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 19, 2023
@tiprow
Copy link

tiprow bot commented Sep 19, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #47092 (8b3b6ce) into master (4450ae4) will decrease coverage by 0.2705%.
Report is 13 commits behind head on master.
The diff coverage is 71.7557%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47092        +/-   ##
================================================
- Coverage   72.9633%   72.6929%   -0.2705%     
================================================
  Files          1337       1359        +22     
  Lines        399007     405580      +6573     
================================================
+ Hits         291129     294828      +3699     
- Misses        89075      92016      +2941     
+ Partials      18803      18736        -67     
Flag Coverage Δ
integration 30.4429% <0.0000%> (?)
unit 73.0392% <71.7557%> (+0.0758%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9620% <ø> (-0.0108%) ⬇️
br 48.7485% <100.0000%> (-4.1912%) ⬇️

@D3Hunter
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 19, 2023
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 19, 2023
@D3Hunter
Copy link
Contributor Author

/retest

disttask/importinto/dispatcher.go Outdated Show resolved Hide resolved
disttask/importinto/dispatcher.go Show resolved Hide resolved
disttask/importinto/encode_and_sort_operator.go Outdated Show resolved Hide resolved
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 20, 2023
@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-19 12:28:57.371211852 +0000 UTC m=+606903.338799902: ☑️ agreed by Benjamin2037.
  • 2023-09-20 08:47:13.446414765 +0000 UTC m=+679999.414002800: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit eb4d1b5 into pingcap:master Sep 20, 2023
4 checks passed
@D3Hunter D3Hunter deleted the import-globalsort-part2 branch September 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants