Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: Avoid type assert for ast.ExprNode #4710

Merged
merged 2 commits into from
Oct 9, 2017
Merged

parser: Avoid type assert for ast.ExprNode #4710

merged 2 commits into from
Oct 9, 2017

Conversation

shenli
Copy link
Member

@shenli shenli commented Oct 4, 2017

Remove most of the type assertions for ast.ExprNode.

For issue #4709

@shenli shenli mentioned this pull request Oct 4, 2017
Open
2 tasks
@shenli
Copy link
Member Author

shenli commented Oct 4, 2017

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Oct 9, 2017

LGTM

1 similar comment
@coocood
Copy link
Member

coocood commented Oct 9, 2017

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 9, 2017
@coocood coocood merged commit a3ce471 into master Oct 9, 2017
@coocood coocood deleted the shenli/parser-expr branch October 9, 2017 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenli @zz-jason @coocood