Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add hex() in tests to avoid non-utf8 chars in result file #47118

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 20, 2023

What problem does this PR solve?

Issue Number: ref #45961

Problem Summary: Because .result file has some non-utf8 characters, github thinks it's a binary file which inconvenient for us to review. Follow MySQL, add hex() function to avoid such problems.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@Defined2014 Defined2014 changed the title tests: add hex() in tests to avoid non utf8 chars tests: add hex() in tests to avoid non-utf8 chars in result file Sep 20, 2023
@tiprow
Copy link

tiprow bot commented Sep 20, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #47118 (0e5d88d) into master (d569d19) will decrease coverage by 0.3448%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head 0e5d88d differs from pull request most recent head f571e52. Consider uploading reports for the commit f571e52 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47118        +/-   ##
================================================
- Coverage   72.9684%   72.6236%   -0.3449%     
================================================
  Files          1338       1359        +21     
  Lines        399152     405441      +6289     
================================================
+ Hits         291255     294446      +3191     
- Misses        89082      92279      +3197     
+ Partials      18815      18716        -99     
Flag Coverage Δ
integration 30.4506% <ø> (?)
unit 72.9684% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9728% <ø> (ø)
br 48.5886% <ø> (-4.3396%) ⬇️

Copy link
Contributor Author

@Defined2014 Defined2014 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 06:25:34.897328589 +0000 UTC m=+671500.864916639: ☑️ agreed by SeaRise.
  • 2023-09-20 09:09:56.207446092 +0000 UTC m=+681362.175034142: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit ad11891 into pingcap:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants