-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add hex()
in tests to avoid non-utf8 chars in result file
#47118
Conversation
hex()
in tests to avoid non utf8 charshex()
in tests to avoid non-utf8 chars in result file
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47118 +/- ##
================================================
- Coverage 72.9684% 72.6236% -0.3449%
================================================
Files 1338 1359 +21
Lines 399152 405441 +6289
================================================
+ Hits 291255 294446 +3191
- Misses 89082 92279 +3197
+ Partials 18815 18716 -99
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/Defined2014/tidb/blob/fix-binary-file/tests/integrationtest/r/expression/builtin.result, github no longer think it is a binary file.
0e5d88d
to
f571e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #45961
Problem Summary: Because
.result
file has some non-utf8 characters, github thinks it's a binary file which inconvenient for us to review. Follow MySQL, addhex()
function to avoid such problems.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.