Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table, tests: move IT test cases in tables to tests/integrationtest #47168

Merged
merged 4 commits into from
Sep 22, 2023
Merged

table, tests: move IT test cases in tables to tests/integrationtest #47168

merged 4 commits into from
Sep 22, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #47160

Problem Summary: Move 27 test cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

Hi @Defined2014. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 21, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/label ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 21, 2023
@Defined2014
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot removed the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #47168 (4db6e53) into master (2680a9a) will decrease coverage by 0.3347%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47168        +/-   ##
================================================
- Coverage   72.9964%   72.6618%   -0.3347%     
================================================
  Files          1338       1359        +21     
  Lines        399462     405751      +6289     
================================================
+ Hits         291593     294826      +3233     
- Misses        89018      92186      +3168     
+ Partials      18851      18739       -112
Flag Coverage Δ
integration 31.8800% <ø> (?)
unit 72.9911% <ø> (-0.0053%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9620% <ø> (ø)
br 48.7477% <ø> (-4.3532%) ⬇️

@Defined2014
Copy link
Contributor Author

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 21, 2023

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 21, 2023
@Defined2014
Copy link
Contributor Author

/cc @tiancaiamao

@ti-chi-bot ti-chi-bot bot requested a review from tiancaiamao September 21, 2023 13:30
@Defined2014
Copy link
Contributor Author

/cc @SeaRise

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

@Defined2014: GitHub didn't allow me to request PR reviews from the following users: SeaRise.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @SeaRise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/cc @YangKeao

@ti-chi-bot ti-chi-bot bot requested a review from YangKeao September 22, 2023 02:06
@Defined2014
Copy link
Contributor Author

/cc @bb7133

@ti-chi-bot ti-chi-bot bot requested a review from bb7133 September 22, 2023 02:06
SeaRise
SeaRise approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-21 10:19:07.028654374 +0000 UTC m=+771912.996242409: ☑️ agreed by hawkingrei.
  • 2023-09-22 03:05:38.756612932 +0000 UTC m=+832304.724200982: ☑️ agreed by SeaRise.

@wuhuizuo
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit aedc611 into pingcap:master Sep 22, 2023
@Defined2014 Defined2014 deleted the move-tables branch September 22, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@SeaRise SeaRise SeaRise approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@YangKeao YangKeao Awaiting requested review from YangKeao

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move IT in table/ to explaintest, files number 12
4 participants
@Defined2014 @wuhuizuo @hawkingrei @SeaRise