-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: avoid glog flags inject into tidb cli #47205
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47205 +/- ##
================================================
+ Coverage 72.9511% 73.1482% +0.1970%
================================================
Files 1340 1369 +29
Lines 399976 412360 +12384
================================================
+ Hits 291787 301634 +9847
- Misses 89282 91885 +2603
+ Partials 18907 18841 -66
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test all |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, tiancaiamao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
What problem does this PR solve?
Issue Number: close #47204
Problem Summary:
What is changed and how it works?
In the initial version, the initialization process would include glog. Now, with this update, we have made a few changes. After the main function starts, the
initflag
function will be cleared first, and then the program will continue to execute.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.