*: remove useless cache in the MergePartitionStats2GlobalStats #47217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47217 +/- ##
================================================
- Coverage 72.9862% 72.4661% -0.5201%
================================================
Files 1340 1367 +27
Lines 400251 411355 +11104
================================================
+ Hits 292128 298093 +5965
- Misses 89191 94402 +5211
+ Partials 18932 18860 -72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
added
the
skip-issue-check
hawkingrei
removed
do-not-merge/needs-tests-checked
skip-issue-check
|
/retest |
time-and-fate
approved these changes
Sep 25, 2023
| } | ||
|
|
||
| for i := 0; i < globalStats.Num; i++ { | ||
| // GetStatsInfo will return the copy of the statsInfo, so we don't need to worry about the memory problem. |
There was a problem hiding this comment.
What "memory problem"? Please be a bit more specific.
There was a problem hiding this comment.
I have updated. it has been changed as data race.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/ok-to-test |
|
/test all |
winoros
approved these changes
Sep 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: time-and-fate, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #47219
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.