Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, tests: move some test cases from admin_test.go and foreign_key_test.go to integrationtest #47333

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Sep 27, 2023

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2023
@tiprow
Copy link

tiprow bot commented Sep 27, 2023

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise SeaRise changed the title Move some test2 executor, tests: move some test cases from admin_test.go and fk_test.go to integrationtest Sep 27, 2023
@SeaRise SeaRise changed the title executor, tests: move some test cases from admin_test.go and fk_test.go to integrationtest executor, tests: move some test cases from admin_test.go and foreign_key_test.go to integrationtest Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #47333 (a50fb50) into master (c98f398) will increase coverage by 0.3674%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47333        +/-   ##
================================================
+ Coverage   72.4871%   72.8546%   +0.3674%     
================================================
  Files          1348       1371        +23     
  Lines        401100     408335      +7235     
================================================
+ Hits         290746     297491      +6745     
- Misses        91238      92037       +799     
+ Partials      19116      18807       -309     
Flag Coverage Δ
integration 38.4242% <ø> (?)
unit 72.6325% <ø> (+0.1454%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.8729% <ø> (+0.0107%) ⬆️
br 48.7421% <ø> (-4.2913%) ⬇️

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 27, 2023

/retest

@tiprow
Copy link

tiprow bot commented Sep 27, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 27, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 28, 2023

/cc @Defined2014 @YangKeao @windtalker

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 12:14:30.865947787 +0000 UTC m=+17668.453057931: ☑️ agreed by hawkingrei.
  • 2023-09-28 03:20:31.373446883 +0000 UTC m=+72028.960557020: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 8cfe7f3 into pingcap:master Sep 28, 2023
@SeaRise SeaRise changed the title executor, tests: move some test cases from admin_test.go and foreign_key_test.go to integrationtest executor, tests: move some test cases from ddl_test.go and split_table_test.go to integrationtest Sep 28, 2023
@SeaRise SeaRise changed the title executor, tests: move some test cases from ddl_test.go and split_table_test.go to integrationtest executor, tests: move some test cases from admin_test.go and foreign_key_test.go to integrationtest Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants