-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: bump mysql-tester version and update result #47358
Conversation
Skipping CI for Draft Pull Request. |
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -12,17 +12,15 @@ Insert N/A root N/A | |||
explain format = 'brief' delete from t where a > 100; | |||
id estRows task access object operator info | |||
Delete N/A root N/A | |||
└─SelectLock 3333.33 root for update 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The is bug of the old mysql-tester, there should not be a SelectLock unless in the 'select ... for update' statement.
@@ -55,14 +55,13 @@ HashJoin 4166.67 root left outer join, equal:[eq(explain_easy.t1.c2, explain_ea | |||
explain format = 'brief' update t1 set t1.c2 = 2 where t1.c1 = 1; | |||
id estRows task access object operator info | |||
Update N/A root N/A | |||
└─Point_Get 1.00 root table:t1 handle:1, lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
@@ -2075,7 +2075,7 @@ EXECUTE mystmt USING @a; | |||
id a | |||
select @@last_plan_from_cache; | |||
@@last_plan_from_cache | |||
0 | |||
1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the correct behaviour --- plan cache been used.
@@ -896,7 +896,7 @@ Projection_3 10000.00 root Column#2, Column#4, Column#5, Column#6, Column#7, Co | |||
└─MemTableScan_4 10000.00 root table:PROCESSLIST | |||
select USER, DB, COMMAND, TIME, STATE, INFO, `DIGEST` from information_schema.processlist; | |||
USER DB COMMAND TIME STATE INFO DIGEST | |||
root planner__cascades__integration Query 0 in transaction; autocommit select USER, DB, COMMAND, TIME, STATE, INFO, `DIGEST` from information_schema.processlist 78f1c0b2fcd082b6504b8ba48706391f13aad730a9efb7ec295688010bfec477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, catch the bug!
@@ -228,20 +228,6 @@ A 1 | |||
Y 1 | |||
a 1 | |||
y 1 | |||
create table strlist(a varchar(10) charset utf8mb4 collate utf8mb4_general_ci, b int) partition by list columns (a) ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
└─Limit_38 382.00 cop[tikv] offset:0, count:382 | ||
└─Selection_33 382.00 cop[tikv] or(and(eq(planner__core__issuetest__planner_issue.tbl_39.col_239, 1994), not(in(planner__core__issuetest__planner_issue.tbl_39.col_239, 2004, 2010, 2010))), and(gt(planner__core__issuetest__planner_issue.tbl_39.col_239, 1996), or(lt(cast(planner__core__issuetest__planner_issue.tbl_39.col_239, double UNSIGNED BINARY), 2026), gt(cast(planner__core__issuetest__planner_issue.tbl_39.col_239, double UNSIGNED BINARY), 2011)))) | ||
└─IndexRangeScan_32 477.50 cop[tikv] table:tbl_39, index:PRIMARY(col_239) range:[1994,1994], (1996,+inf], keep order:true, stats:pseudo | ||
Projection_8 382.00 root planner__core__issuetest__planner_issue.tbl_39.col_239 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result before and after are both correct, it seems the 'tidb_partition_prune_mode' differ.
CREATE TABLE IF NOT EXISTS t(a int); | ||
IMPORT INTO t FROM '/file.csv'; | ||
Error 1105 (HY000): cannot run IMPORT INTO in explicit transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old error is wrong ... catch the bug!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47358 +/- ##
================================================
+ Coverage 72.2972% 72.7209% +0.4237%
================================================
Files 1352 1373 +21
Lines 401072 407412 +6340
================================================
+ Hits 289964 296274 +6310
- Misses 91884 92339 +455
+ Partials 19224 18799 -425
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tiancaiamao should fix the We could use Maybe forgot update |
tests/integrationtest/r/planner/core/integration_partition.result
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
A new PR merged. #47420 |
What problem does this PR solve?
Issue Number: ref #45961
Problem Summary:
What is changed and how it works?
After mysql-tester commit pingcap/mysql-tester#105
Several bugs are found and the test result need to update.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.