tests: bump mysql-tester version and update result #47358

tiancaiamao · 2023-09-28T07:19:34Z

What problem does this PR solve?

Issue Number: ref #45961

Problem Summary:

What is changed and how it works?

After mysql-tester commit pingcap/mysql-tester#105
Several bugs are found and the test result need to update.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-09-28T07:19:36Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2023-09-28T07:19:58Z

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2023-09-28T07:20:02Z

tests/integrationtest/r/explain-non-select-stmt.result

@@ -12,17 +12,15 @@ Insert	N/A	root		N/A
 explain format = 'brief' delete from t where a > 100;
 id	estRows	task	access object	operator info
 Delete	N/A	root		N/A
-└─SelectLock	3333.33	root		for update 0


The is bug of the old mysql-tester, there should not be a SelectLock unless in the 'select ... for update' statement.

tiancaiamao · 2023-09-28T07:20:46Z

tests/integrationtest/r/explain_easy.result

@@ -55,14 +55,13 @@ HashJoin	4166.67	root		left outer join, equal:[eq(explain_easy.t1.c2, explain_ea
 explain format = 'brief' update t1 set t1.c2 = 2 where t1.c1 = 1;
 id	estRows	task	access object	operator info
 Update	N/A	root		N/A
-└─Point_Get	1.00	root	table:t1	handle:1, lock


tiancaiamao · 2023-09-28T07:22:25Z

tests/integrationtest/r/expression/issues.result

@@ -2075,7 +2075,7 @@ EXECUTE mystmt USING @a;
 id	a
 select @@last_plan_from_cache;
 @@last_plan_from_cache
-0
+1


This should be the correct behaviour --- plan cache been used.

tiancaiamao · 2023-09-28T07:23:18Z

tests/integrationtest/r/planner/cascades/integration.result

@@ -896,7 +896,7 @@ Projection_3	10000.00	root		Column#2, Column#4, Column#5, Column#6, Column#7, Co
 └─MemTableScan_4	10000.00	root	table:PROCESSLIST	
 select USER, DB, COMMAND, TIME, STATE, INFO, `DIGEST` from information_schema.processlist;
 USER	DB	COMMAND	TIME	STATE	INFO	DIGEST
-root	planner__cascades__integration	Query	0	in transaction; autocommit	select USER, DB, COMMAND, TIME, STATE, INFO, `DIGEST` from information_schema.processlist	78f1c0b2fcd082b6504b8ba48706391f13aad730a9efb7ec295688010bfec477


Aha, catch the bug!

tiancaiamao · 2023-09-28T07:24:18Z

tests/integrationtest/r/planner/core/integration.result

@@ -228,20 +228,6 @@ A	1
 Y	1
 a	1
 y	1
-create table strlist(a varchar(10) charset utf8mb4 collate utf8mb4_general_ci, b int) partition by list columns (a) (


See here https://github.com/pingcap/tidb/pull/47358/files#diff-77ff1acea637e7d56230082a1f744f3454394f05500d2b6cc9f52710e8671c37R175

tiancaiamao · 2023-09-28T07:25:34Z

tests/integrationtest/r/planner/core/issuetest/planner_issue.result

-  └─Limit_38	382.00	cop[tikv]		offset:0, count:382
-    └─Selection_33	382.00	cop[tikv]		or(and(eq(planner__core__issuetest__planner_issue.tbl_39.col_239, 1994), not(in(planner__core__issuetest__planner_issue.tbl_39.col_239, 2004, 2010, 2010))), and(gt(planner__core__issuetest__planner_issue.tbl_39.col_239, 1996), or(lt(cast(planner__core__issuetest__planner_issue.tbl_39.col_239, double UNSIGNED BINARY), 2026), gt(cast(planner__core__issuetest__planner_issue.tbl_39.col_239, double UNSIGNED BINARY), 2011))))
-      └─IndexRangeScan_32	477.50	cop[tikv]	table:tbl_39, index:PRIMARY(col_239)	range:[1994,1994], (1996,+inf], keep order:true, stats:pseudo
+Projection_8	382.00	root		planner__core__issuetest__planner_issue.tbl_39.col_239


The result before and after are both correct, it seems the 'tidb_partition_prune_mode' differ.

tiancaiamao · 2023-09-28T07:26:16Z

tests/integrationtest/r/privilege/privileges.result

 CREATE TABLE IF NOT EXISTS t(a int);
 IMPORT INTO t FROM '/file.csv';
-Error 1105 (HY000): cannot run IMPORT INTO in explicit transaction


The old error is wrong ... catch the bug!

YangKeao

Rest LGTM

tests/integrationtest/t/planner/core/integration.test

codecov · 2023-09-28T07:35:53Z

Codecov Report

Merging #47358 (4098ed2) into master (b431900) will increase coverage by 0.4237%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47358        +/-   ##
================================================
+ Coverage   72.2972%   72.7209%   +0.4237%     
================================================
  Files          1352       1373        +21     
  Lines        401072     407412      +6340     
================================================
+ Hits         289964     296274      +6310     
- Misses        91884      92339       +455     
+ Partials      19224      18799       -425

Flag	Coverage Δ
integration	`38.6221% <ø> (?)`
unit	`72.2810% <ø> (-0.0162%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`84.7544% <ø> (-0.0108%)`	⬇️
br	`48.8649% <ø> (-4.3260%)`	⬇️

tiancaiamao · 2023-09-28T13:21:26Z

/test check-dev2
/test check-dev

tiprow · 2023-09-28T13:22:01Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2
/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Defined2014 · 2023-10-07T09:01:13Z

@tiancaiamao should fix the check_dev and check_dev_2

We could use ./run-tests.sh -r all to generate all results.

Maybe forgot update run-tests.sh script.

tests/integrationtest/r/planner/core/integration_partition.result

YangKeao

Rest LGTM

tests/integrationtest/r/planner/core/integration_partition.result

ti-chi-bot · 2023-10-07T12:09:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Defined2014,YangKeao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-10-07T12:09:48Z

[LGTM Timeline notifier]

Timeline:

2023-10-07 10:04:34.413505782 +0000 UTC m=+873872.000615929: ☑️ agreed by Defined2014.
2023-10-07 12:09:47.338387151 +0000 UTC m=+881384.925497296: ☑️ agreed by YangKeao.

tests/integrationtest/run-tests.sh

YangKeao · 2023-10-08T04:11:37Z

executor/write failed, but I cannot reproduce on my local machine 🤔

run test [executor/write] err: sql:update t set id=id+17 where id in (3,10);: failed to run query 
"update t set id=id+17 where id in (3,10);" 
 around line 612, 
we need(99):
update t set id=id+17 where id in (3,10);
Error 1526 (HY000): Table has no partition for value 27
s
but got(99):
update t set id=id+17 where id in (3,10);
Error 1062 (23000): Duplicate entry '20' for key 't.idx'

/retest

Defined2014 · 2023-10-08T04:14:28Z

executor/write failed, but I cannot reproduce on my local machine 🤔

run test [executor/write] err: sql:update t set id=id+17 where id in (3,10);: failed to run query 
"update t set id=id+17 where id in (3,10);" 
 around line 612, 
we need(99):
update t set id=id+17 where id in (3,10);
Error 1526 (HY000): Table has no partition for value 27
s
but got(99):
update t set id=id+17 where id in (3,10);
Error 1062 (23000): Duplicate entry '20' for key 't.idx'

/retest

A new PR merged. #47420

tiancaiamao added 4 commits September 27, 2023 22:22

update for mysql-tester

4a13c2c

save

1653685

Merge branch 'master' into update-mysql-tester

d740d6c

run tests

3192d50

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 28, 2023

tiancaiamao commented Sep 28, 2023

View reviewed changes

tiancaiamao marked this pull request as ready for review September 28, 2023 07:26

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2023

YangKeao reviewed Sep 28, 2023

View reviewed changes

tests/integrationtest/t/planner/core/integration.test Outdated Show resolved Hide resolved

Defined2014 reviewed Sep 28, 2023

View reviewed changes

tests/integrationtest/t/planner/core/integration.test Outdated Show resolved Hide resolved

tests/integrationtest/t/planner/core/integration.test Outdated Show resolved Hide resolved

resolve conflict

0423b54

tiancaiamao added 2 commits October 7, 2023 17:08

Merge branch 'master' into update-mysql-tester

e29c3d1

address comment

faa3931

Defined2014 reviewed Oct 7, 2023

View reviewed changes

tests/integrationtest/r/planner/core/integration_partition.result Outdated Show resolved Hide resolved

address comment

8aa12bb

Defined2014 approved these changes Oct 7, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 7, 2023

sorted result unstable between NULL and empty string ""?

c781be7

YangKeao approved these changes Oct 7, 2023

View reviewed changes

tests/integrationtest/r/planner/core/integration_partition.result Show resolved Hide resolved

ti-chi-bot bot added the lgtm label Oct 7, 2023

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 7, 2023

Defined2014 reviewed Oct 8, 2023

View reviewed changes

tests/integrationtest/run-tests.sh Outdated Show resolved Hide resolved

update mysql-tester

89e9d0d

Merge branch 'master' into update-mysql-tester

4098ed2

ti-chi-bot bot merged commit 2d1d3fd into pingcap:master Oct 8, 2023
12 of 15 checks passed

Defined2014 mentioned this pull request Oct 8, 2023

flaky test integrationtest.sh #47432

Closed

tiancaiamao deleted the update-mysql-tester branch October 8, 2023 05:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: bump mysql-tester version and update result #47358

tests: bump mysql-tester version and update result #47358

tiancaiamao commented Sep 28, 2023

ti-chi-bot bot commented Sep 28, 2023

tiprow bot commented Sep 28, 2023

tiancaiamao Sep 28, 2023

tiancaiamao Sep 28, 2023

tiancaiamao Sep 28, 2023

tiancaiamao Sep 28, 2023

tiancaiamao Sep 28, 2023

tiancaiamao Sep 28, 2023

tiancaiamao Sep 28, 2023

YangKeao left a comment

codecov bot commented Sep 28, 2023 •

edited

Loading

tiancaiamao commented Sep 28, 2023

tiprow bot commented Sep 28, 2023

Defined2014 commented Oct 7, 2023 •

edited

Loading

YangKeao left a comment

ti-chi-bot bot commented Oct 7, 2023

ti-chi-bot bot commented Oct 7, 2023

YangKeao commented Oct 8, 2023

Defined2014 commented Oct 8, 2023

tests: bump mysql-tester version and update result #47358

tests: bump mysql-tester version and update result #47358

Conversation

tiancaiamao commented Sep 28, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Sep 28, 2023

tiprow bot commented Sep 28, 2023

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

tiancaiamao Sep 28, 2023

Choose a reason for hiding this comment

YangKeao left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 28, 2023 • edited Loading

Codecov Report

tiancaiamao commented Sep 28, 2023

tiprow bot commented Sep 28, 2023

Defined2014 commented Oct 7, 2023 • edited Loading

YangKeao left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 7, 2023

ti-chi-bot bot commented Oct 7, 2023

[LGTM Timeline notifier]

YangKeao commented Oct 8, 2023

Defined2014 commented Oct 8, 2023

codecov bot commented Sep 28, 2023 •

edited

Loading

Defined2014 commented Oct 7, 2023 •

edited

Loading