-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, tests: move some test cases from ddl_test.go
, split_table_test.go
and write_test.go
to integrationtest
#47361
Conversation
Hi @SeaRise. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
admin_test.go
and foreign_key_test.go
to integrationtest
ddl_test.go
and split_table_test.go
to integrationtest
ddl_test.go
and split_table_test.go
to integrationtest
ddl_test.go
and split_table_test.go
to integrationtest
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47361 +/- ##
================================================
+ Coverage 72.3296% 72.7270% +0.3974%
================================================
Files 1350 1373 +23
Lines 400999 407301 +6302
================================================
+ Hits 290041 296218 +6177
- Misses 91759 92328 +569
+ Partials 19199 18755 -444
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
ddl_test.go
and split_table_test.go
to integrationtest
ddl_test.go
, split_table_test.go
and write_test.go
to integrationtest
[LGTM Timeline notifier]Timeline:
|
@YangKeao Found an unstable tests, need add |
/test check-dev2 |
@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei, tiancaiamao, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #47076
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.