-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix DST times for adding index (#47425) #47447
ddl: fix DST times for adding index (#47425) #47447
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47447 +/- ##
================================================
Coverage ? 73.6477%
================================================
Files ? 1085
Lines ? 348930
Branches ? 0
================================================
Hits ? 256979
Misses ? 75474
Partials ? 16477 |
This is an automated cherry-pick of #47425
What problem does this PR solve?
Issue Number: close #47426, ref #46033
Problem Summary:
I did not consider DST values in #46055. As a result, the timezone names are always ignored. It may cause data inconsistency when TiDB encounters DST values during adding index.
What is changed and how it works?
GetTimeZone()
becauseTimeZoneLocation.GetLocation()
could handle the empty strings properly. Thus, the priority betweentime_zone_name
andtime_zone_offset
is preserved.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.