Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix bug when build histograms for columns #4757

Merged
merged 2 commits into from
Oct 12, 2017
Merged

stats: fix bug when build histograms for columns #4757

merged 2 commits into from
Oct 12, 2017

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 12, 2017

Sometimes the NDV calculated from FM Sketch may larger than row count, which will make the ndvFactor less than 1, and the Repeats less than 1.

@zz-jason
Copy link
Member

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx merged commit a5266d6 into master Oct 12, 2017
@alivxxx alivxxx deleted the xhb/fix branch October 12, 2017 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants