Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: fix bug about copy function. #4765

Merged
merged 1 commit into from
Oct 13, 2017
Merged

plan: fix bug about copy function. #4765

merged 1 commit into from
Oct 13, 2017

Conversation

hanfei1991
Copy link
Member

When we copy a plan, we should also copy its expected count.

@coocood
Copy link
Member

coocood commented Oct 13, 2017

LGTM

alivxxx
alivxxx approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros
Copy link
Member

winoros commented Oct 13, 2017

Keep expectedCnt in basePhysicalPlan and change the newBasePhysicalPlan() is better?
@coocood @hanfei1991

@hanfei1991 hanfei1991 merged commit 2efa9ba into master Oct 13, 2017
@hanfei1991 hanfei1991 deleted the hanfei/copy branch October 13, 2017 08:24
@hanfei1991 hanfei1991 mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanfei1991 @coocood @winoros @alivxxx