Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, tests: move test cases from union_scan_test.go and kv_test.go to integrationtest #47659

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Oct 16, 2023

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary: move 8 test cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 16, 2023
@tiprow
Copy link

tiprow bot commented Oct 16, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #47659 (ffde4bd) into master (476d9b3) will increase coverage by 0.8934%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47659        +/-   ##
================================================
+ Coverage   71.9335%   72.8270%   +0.8934%     
================================================
  Files          1396       1419        +23     
  Lines        404732     411151      +6419     
================================================
+ Hits         291138     299429      +8291     
+ Misses        94000      92880      -1120     
+ Partials      19594      18842       -752     
Flag Coverage Δ
integration 41.3475% <ø> (?)
unit 71.9245% <ø> (-0.0090%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6617% <ø> (-4.2547%) ⬇️

@Defined2014 Defined2014 changed the title executor, tests: move test cases from union_scan_test.go to integrationtest executor, tests: move test cases from union_scan_test.go and kv_test.go to integrationtest Oct 16, 2023
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 07:57:27.361451812 +0000 UTC m=+1643844.948561958: ☑️ agreed by hawkingrei.
  • 2023-10-16 08:17:04.993108495 +0000 UTC m=+1645022.580218632: ☑️ agreed by YangKeao.

@Defined2014
Copy link
Contributor Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Oct 16, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit f4f8cd6 into pingcap:master Oct 16, 2023
13 of 16 checks passed
@Defined2014 Defined2014 deleted the move-union-scan branch October 16, 2023 09:13
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants