Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move more methods from StatsHandle to its sub-packages #47696

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Oct 17, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: move more methods from StatsHandle to its sub-packages

What is changed and how it works?

planner: move more methods from StatsHandle to its sub-packages

No logical change, just refactor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2023
@tiprow
Copy link

tiprow bot commented Oct 17, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #47696 (c219d39) into master (5ac13d9) will increase coverage by 1.3718%.
Report is 9 commits behind head on master.
The diff coverage is 71.0743%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47696        +/-   ##
================================================
+ Coverage   71.8864%   73.2583%   +1.3718%     
================================================
  Files          1398       1420        +22     
  Lines        405057     418115     +13058     
================================================
+ Hits         291181     306304     +15123     
+ Misses        94266      92708      -1558     
+ Partials      19610      19103       -507     
Flag Coverage Δ
integration 41.9817% <34.7107%> (?)
unit 72.4296% <71.0743%> (+0.5432%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 49.2515% <100.0000%> (-3.6670%) ⬇️

@qw4990 qw4990 added the sig/planner SIG: Planner label Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 17, 2023
@hawkingrei
Copy link
Member

/retest

Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

br part change lgtm.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 04:48:37.95940755 +0000 UTC m=+1718915.546517687: ☑️ agreed by hawkingrei.
  • 2023-10-17 05:54:00.267675843 +0000 UTC m=+1722837.854785973: ☑️ agreed by BornChanger.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 17, 2023
@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test c219d39 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 17, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 17, 2023

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit aebf22d into pingcap:master Oct 17, 2023
31 of 39 checks passed
@hawkingrei
Copy link
Member

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #47727.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants