-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix some test cases in real TiKV env #47697
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -41,6 +41,7 @@ drop table if exists local_temporary_admin_checksum_table_with_index_test,local_ | |||
|
|||
# TestAdminCheckIndexInCacheTable | |||
drop table if exists cache_admin_test; | |||
--disable_result_log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like test before, we needn't check result log.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47697 +/- ##
================================================
+ Coverage 71.8756% 73.2539% +1.3783%
================================================
Files 1396 1421 +25
Lines 404969 417725 +12756
================================================
+ Hits 291074 306000 +14926
+ Misses 94275 92586 -1689
+ Partials 19620 19139 -481
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #45961, close #49177
Problem Summary: We found
check_dev2
didn't enable real tikv env correct before. When we try to enable it, found some problems need to fix. PingCAP-QE/ci#2519 (comment)Also found 4 issues with real tikv
field
func andutf8mb4_general_ci
in real TiKV env #47688admin recover index
report error with real TiKV #47687What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.