Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix some test cases in real TiKV env #47697

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Oct 17, 2023

What problem does this PR solve?

Issue Number: ref #45961, close #49177

Problem Summary: We found check_dev2 didn't enable real tikv env correct before. When we try to enable it, found some problems need to fix. PingCAP-QE/ci#2519 (comment)

Also found 4 issues with real tikv

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2023
@tiprow
Copy link

tiprow bot commented Oct 17, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -41,6 +41,7 @@ drop table if exists local_temporary_admin_checksum_table_with_index_test,local_

# TestAdminCheckIndexInCacheTable
drop table if exists cache_admin_test;
--disable_result_log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like test before, we needn't check result log.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #47697 (c9cdf28) into master (ab4c20b) will increase coverage by 1.3783%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47697        +/-   ##
================================================
+ Coverage   71.8756%   73.2539%   +1.3783%     
================================================
  Files          1396       1421        +25     
  Lines        404969     417725     +12756     
================================================
+ Hits         291074     306000     +14926     
+ Misses        94275      92586      -1689     
+ Partials      19620      19139       -481     
Flag Coverage Δ
integration 41.2951% <ø> (?)
unit 72.4069% <ø> (+0.5313%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 49.4653% <ø> (-3.4866%) ⬇️

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 05:18:27.827752887 +0000 UTC m=+1720705.414863032: ☑️ agreed by hawkingrei.
  • 2023-10-17 07:37:53.187922489 +0000 UTC m=+1729070.775032635: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit d0a5bc5 into pingcap:master Oct 17, 2023
14 of 16 checks passed
@lcwangchao lcwangchao added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 5, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49172.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 5, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2023
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrationtest failed in some env
5 participants