Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: add log to show reason for partition table's auto analyze #47708

Merged
merged 2 commits into from
Oct 17, 2023
Merged

statistics: add log to show reason for partition table's auto analyze #47708

merged 2 commits into from
Oct 17, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
statistics: add log to show reason for partition table's auto analyze
f416f61 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 17, 2023
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #47708 (8afe8ee) into master (1978479) will increase coverage by 0.9012%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47708        +/-   ##
================================================
+ Coverage   71.8897%   72.7910%   +0.9012%     
================================================
  Files          1398       1421        +23     
  Lines        405084     411467      +6383     
================================================
+ Hits         291214     299511      +8297     
+ Misses        94260      93106      -1154     
+ Partials      19610      18850       -760
Flag Coverage Δ
integration 41.3415% <0.0000%> (?)
unit 71.8896% <100.0000%> (-0.0002%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7023% <ø> (-4.2626%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
time-and-fate
time-and-fate reviewed Oct 17, 2023
View reviewed changes
pkg/statistics/handle/autoanalyze/autoanalyze.go
partitionNames = append(partitionNames, def.Name.O)
logutil.BgLogger().Info("need to auto analyze", zap.String("category", "stats"),
zap.String("table", tblInfo.Name.String()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to have db name also printed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [time-and-fate,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 07:38:04.603360954 +0000 UTC m=+1729082.190471113: ☑️ agreed by winoros.
  • 2023-10-17 08:04:45.414900681 +0000 UTC m=+1730683.002010826: ☑️ agreed by time-and-fate.

@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2023
@hawkingrei
update
8afe8ee 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 59258d9 into pingcap:master Oct 17, 2023
13 of 16 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 18, 2023
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #47747.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@ti-chi-bot
statistics: add log to show reason for partition table's auto analyze (…
c53993b 
…#47708) (#47747)

close #47748
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
@hawkingrei @wuhuizuo
statistics: add log to show reason for partition table's auto analyze (…
cc886b8 
…pingcap#47708)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @winoros @time-and-fate