-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, planner: fix plan_replayer zip format (#47474) #47714
executor, planner: fix plan_replayer zip format (#47474) #47714
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrysan, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47714 +/- ##
================================================
Coverage ? 73.6818%
================================================
Files ? 1085
Lines ? 348402
Branches ? 0
================================================
Hits ? 256709
Misses ? 75224
Partials ? 16469 |
/retest |
This is an automated cherry-pick of #47474
What problem does this PR solve?
Issue Number: close #46474
Problem Summary:
If the zip file dumped by
plan replayer dump
is unzipped and zipped again, a normal compression software will always add entries for directories, such asstats/
... They are just directories and cannot be read, so we should skip them to avoid returning error.What is changed and how it works?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.