Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add tiproxy in cluster_config #47785

Merged
merged 3 commits into from
Oct 31, 2023
Merged

executor: add tiproxy in cluster_config #47785

merged 3 commits into from
Oct 31, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Oct 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #47784

Problem Summary: As title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
executor: add tiproxy in cluster_config
489d338 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2023
@xhebox xhebox requested a review from djshow832 October 19, 2023 08:18
@tiprow
Copy link

tiprow bot commented Oct 19, 2023

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #47785 (d2a0bb5) into master (6166594) will increase coverage by 2.1701%.
Report is 89 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47785        +/-   ##
================================================
+ Coverage   71.8642%   74.0344%   +2.1701%     
================================================
  Files          1398       1426        +28     
  Lines        405200     425848     +20648     
================================================
+ Hits         291194     315274     +24080     
+ Misses        94374      91640      -2734     
+ Partials      19632      18934       -698
Flag Coverage Δ
integration 43.8471% <0.0000%> (?)
unit 73.2607% <100.0000%> (+1.3965%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.5260% <ø> (+1.5347%) ⬆️
parser ∅ <ø> (∅)
br 48.9654% <ø> (-3.9720%) ⬇️

djshow832
djshow832 reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests, at least in memtable_reader_test.go.

@xhebox
add tests
a28ff0e 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2023
@xhebox
fix test
d2a0bb5 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2023
@xhebox xhebox requested a review from djshow832 October 19, 2023 10:01
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 20, 2023
@djshow832
Copy link
Contributor

TiProxy is not released yet, so I don't think it's a good idea to add release notes.

@xhebox
Copy link
Contributor Author

xhebox commented Oct 30, 2023

TiProxy is not released yet, so I don't think it's a good idea to add release notes.

Then, you will have to add release notes back in the future. But I think we will forget it.

@djshow832
Copy link
Contributor

TiProxy is not released yet, so I don't think it's a good idea to add release notes.

Then, you will have to add release notes back in the future. But I think we will forget it.

No, we don't need to. When TiProxy is released, we just add release notes of TiProxy and don't need every single change of TiDB.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [djshow832,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 06:19:11.332828069 +0000 UTC m=+1983548.919938212: ☑️ agreed by djshow832.
  • 2023-10-31 07:42:41.835234247 +0000 UTC m=+2938959.422344392: ☑️ agreed by hawkingrei.

@xhebox
Copy link
Contributor Author

xhebox commented Oct 31, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 31, 2023

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor Author

xhebox commented Oct 31, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 31, 2023

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor Author

xhebox commented Oct 31, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 31, 2023

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor Author

xhebox commented Oct 31, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 31, 2023
@xhebox
Copy link
Contributor Author

xhebox commented Oct 31, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 56e0959 into pingcap:master Oct 31, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tiproxy for cluster_info
3 participants
@xhebox @djshow832 @hawkingrei