-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: unify the way to handle txn in statshandle
#47859
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47859 +/- ##
================================================
+ Coverage 71.8756% 72.8037% +0.9280%
================================================
Files 1399 1422 +23
Lines 405325 411810 +6485
================================================
+ Hits 291330 299813 +8483
+ Misses 94353 93144 -1209
+ Partials 19642 18853 -789
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3d57ebe
to
945fa99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍🏿
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Rustin Liu <rustin.liu@gmail.com>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #46905
Problem Summary: planner: unify the way to handle txn in
statshandle
What is changed and how it works?
planner: unify the way to handle txn in
statshandle
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.