Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: unify the way to handle txn in statshandle #47859

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Oct 20, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: unify the way to handle txn in statshandle

What is changed and how it works?

planner: unify the way to handle txn in statshandle

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
@tiprow
Copy link

tiprow bot commented Oct 20, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #47859 (5c25c1f) into master (9f97c9a) will increase coverage by 0.9280%.
Report is 5 commits behind head on master.
The diff coverage is 91.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47859        +/-   ##
================================================
+ Coverage   71.8756%   72.8037%   +0.9280%     
================================================
  Files          1399       1422        +23     
  Lines        405325     411810      +6485     
================================================
+ Hits         291330     299813      +8483     
+ Misses        94353      93144      -1209     
+ Partials      19642      18853       -789     
Flag Coverage Δ
integration 41.4921% <75.0000%> (?)
unit 71.8620% <91.6666%> (-0.0137%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7079% <ø> (-4.2693%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏿

pkg/statistics/handle/util/util.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 08:26:35.858914387 +0000 UTC m=+1991193.446024528: ☑️ agreed by hawkingrei.
  • 2023-10-20 08:42:57.491381089 +0000 UTC m=+1992175.078491234: ☑️ agreed by hi-rustin.

Co-authored-by: Rustin Liu <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot merged commit 36160d1 into pingcap:master Oct 20, 2023
12 of 15 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #47889.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants