Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb/tikv: return MySQL error code for Unsafe SafePoint #4786

Merged
merged 6 commits into from
Oct 17, 2017

Conversation

atmzhou
Copy link
Contributor

@atmzhou atmzhou commented Oct 16, 2017

When start timestamp of a transaction falls behind the safepoint, it returns MySQL Error Code. This indicates the user that larger GC Interval should be set.
When start timestamp of a transaction may fall behind the safepoint, it returns PDServerTimeout. This is the reason for aborting the transaction.

@atmzhou atmzhou requested a review from disksing October 16, 2017 09:33
@shenli
Copy link
Member

shenli commented Oct 16, 2017

LGTM
Please update this doc.

Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@disksing disksing merged commit 0bf3614 into master Oct 17, 2017
@disksing disksing deleted the ningnanzhou/errcode_safepoint branch October 17, 2017 05:40
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants