Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: fix the issue cannot create dict follower constraints (#47750) #47890

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47750

What problem does this PR solve?

Issue Number: close #47741
Problem Summary:

Minimal reproduce step

mysql> CREATE PLACEMENT POLICY ssd FOLLOWER_CONSTRAINTS="{+disk=ssd: 1}";
ERROR 1105 (HY000): label constraints with invalid REPLICAS: count of replicas in dict constrains is 1, but got 2: invalid FollowerConstraints

What is changed and how it works?

skip the checks.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 20, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 23, 2023
@nolouch
Copy link
Member

nolouch commented Oct 23, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 23, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-23 03:20:31.100645726 +0000 UTC m=+2232028.687755871: ☑️ agreed by nolouch.
  • 2023-10-23 03:37:55.27498202 +0000 UTC m=+2233072.862092150: ☑️ agreed by CabinfeverB.

@nolouch
Copy link
Member

nolouch commented Oct 23, 2023

ptal @xhebox

@nolouch nolouch requested a review from xhebox October 23, 2023 03:54
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, nolouch, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 23, 2023
@nolouch
Copy link
Member

nolouch commented Oct 23, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit a5073a3 into pingcap:release-7.5 Oct 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants