Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refine job_type of admin show ddl jobs (#47699) #48002

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47699

What problem does this PR solve?

Issue Number: ref #45719

Problem Summary:

The result of ADMIN SHOW DDL JOBS does not indicate whether global sort is used.

What is changed and how it works?

Add /* cloud */ to JOB_TYPE field if global sort is used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Multi-schema change job:
    |    113 | test    | t          | alter table multi-schema change           | none         |         2 |      105 |         0 | 2023-10-17 13:22:31 | 2023-10-17 13:22:31 | 2023-10-17 13:22:37 | synced |
    |    113 | test    | t          | add index /* subjob */ /* ingest cloud */ | public       |         2 |      105 |         1 | 2023-10-17 13:22:31 | 2023-10-17 13:22:31 | 2023-10-17 13:22:37 | done   |
    
    Plain job:
    |    109 | test    | t          | add index /* ingest cloud */              | public       |         2 |      105 |         1 | 2023-10-17 13:10:15 | 2023-10-17 13:10:15 | 2023-10-17 13:10:23 | synced |
    
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanfei1991 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 eeb78d3 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tangenta
Copy link
Contributor

tangenta commented Nov 2, 2023

Cherry-picked in #48250.

@tangenta tangenta closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants