Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: move IT in executor to tests/integrationtest (PART 8) #48098

Merged
merged 6 commits into from
Nov 1, 2023
Merged

tests: move IT in executor to tests/integrationtest (PART 8) #48098

merged 6 commits into from
Nov 1, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 30, 2023
@tiprow
Copy link

tiprow bot commented Oct 30, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #48098 (963ed89) into master (173e485) will increase coverage by 1.2051%.
Report is 29 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48098        +/-   ##
================================================
+ Coverage   71.5914%   72.7965%   +1.2051%     
================================================
  Files          1401       1423        +22     
  Lines        405923     412444      +6521     
================================================
+ Hits         290606     300245      +9639     
+ Misses        95508      93291      -2217     
+ Partials      19809      18908       -901
Flag Coverage Δ
integration 42.6227% <ø> (?)
unit 71.5266% <ø> (-0.0648%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (-0.0629%) ⬇️
parser ∅ <ø> (∅)
br 48.6438% <ø> (-4.2594%) ⬇️

@Defined2014 Defined2014 force-pushed the move-executor-part8 branch 2 times, most recently from 27373fe to 92398af Compare October 30, 2023 14:31
@Defined2014
update sample
ff81372 
update simple_test

update statement_context

update window

update update.test
@Defined2014 Defined2014 force-pushed the move-executor-part8 branch 2 times, most recently from 71ba0aa to ff81372 Compare November 1, 2023 03:19
@Defined2014
Copy link
Contributor Author

@SeaRise @YangKeao PTAL

SeaRise
SeaRise approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

tests/integrationtest/t/executor/aggregate.test Outdated Show resolved Hide resolved
tests/integrationtest/t/executor/aggregate.test Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 1, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 09:21:55.807773723 +0000 UTC m=+2858513.394883852: ☑️ agreed by hawkingrei.
  • 2023-11-01 05:58:33.096426749 +0000 UTC m=+3019110.683536896: ☑️ agreed by SeaRise.

@SeaRise
Copy link
Contributor

SeaRise commented Nov 1, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2023
@SeaRise
Copy link
Contributor

SeaRise commented Nov 1, 2023 •
edited
Loading

Comment /unhold cancel when you want to merge pr @Defined2014

@Defined2014
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit d380ef4 into pingcap:master Nov 1, 2023
12 of 15 checks passed
@Defined2014 Defined2014 deleted the move-executor-part8 branch November 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Defined2014 @SeaRise @hawkingrei