-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: refine info cache logic to reduce the impact of DDL on information schema cache #48284
infoschema: refine info cache logic to reduce the impact of DDL on information schema cache #48284
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@lcwangchao @cfzjywxk PTAL |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48284 +/- ##
================================================
+ Coverage 71.4920% 73.0652% +1.5732%
================================================
Files 1402 1425 +23
Lines 406343 416121 +9778
================================================
+ Hits 290503 304040 +13537
+ Misses 96004 93139 -2865
+ Partials 19836 18942 -894
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add more comments
[LGTM Timeline notifier]Timeline:
|
/cc @zimulala @wjhuang2016 @tangenta PTAL |
@cfzjywxk: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, lcwangchao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required |
/retest |
In response to a cherrypick label: new pull request created to branch |
…formation schema cache (pingcap#48284) close pingcap#48285 Signed-off-by: crazycs520 <crazycs520@gmail.com>
…formation schema cache (pingcap#48284) close pingcap#48285
What problem does this PR solve?
Issue Number: close #48285
Problem Summary: refine info cache logic to reduce the impact of DDL on information schema cache
What is changed and how it works?
Do same test in #48285, with this PR, the impact of
failed to get schema version
to stale read QPS is much smaller.The the related metric is following, as you can see, the QPS is much more stable and load snapshot ops is much lower.
Before This PR
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.