Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix create and alter check constraints problems (#47633) #48390

Merged
merged 4 commits into from
Feb 1, 2024
Merged

ddl: fix create and alter check constraints problems (#47633) #48390

merged 4 commits into from
Feb 1, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 8, 2023 •
edited by fzzf678
Loading

This is an automated cherry-pick of #47633

What problem does this PR solve?

Issue Number: close #47567 close #47631 close #47632

It seems also close #44737

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix create and alter check constraints problems.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2023
Merged
13 tasks
@CbcWestwolf CbcWestwolf closed this Dec 8, 2023
@fzzf678 fzzf678 reopened this Feb 1, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-01 08:43:37.570980776 +0000 UTC m=+1641459.135278503: ☑️ agreed by fzzf678.
  • 2024-02-01 08:44:43.360983846 +0000 UTC m=+1641524.925281551: ☑️ agreed by CbcWestwolf.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, fzzf678, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 1, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@817b4fc). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #48390   +/-   ##
================================================
  Coverage               ?   71.9858%           
================================================
  Files                  ?       1401           
  Lines                  ?     406744           
  Branches               ?          0           
================================================
  Hits                   ?     292798           
  Misses                 ?      94235           
  Partials               ?      19711
Flag Coverage Δ
unit 71.9858% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2601% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 181f71c into pingcap:release-7.5 Feb 1, 2024
18 checks passed
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 7, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 7, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzzf678 fzzf678 fzzf678 approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees

@jiyfhust jiyfhust

Labels
approved do-not-merge/cherry-pick-not-approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @CbcWestwolf @ywqzzy @fzzf678 @jiyfhust