Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor/brie: use the default value from flags (#48025) #48441

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48025

What problem does this PR solve?

Issue Number: close #48000

Problem Summary:
The current default config parameter is different from the BR CLI's. For example, SkipStatistics is always false (in BR it is defaultly true), UseCheckpoint is always false too (in BR it is defaultly true).

What is changed and how it works?

This PR exports the default config via the command line parameter of BR. And we will use it at the BRIE via SQL.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Now, BRIE via SQL will use the same default config with BR CLI.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 23, 2023
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 23, 2023
Copy link

ti-chi-bot bot commented Nov 23, 2023

@YuJuncen: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 23, 2023
Copy link

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 23, 2023
Copy link

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 11:14:53.725752918 +0000 UTC m=+489322.390979113: ☑️ agreed by YuJuncen.
  • 2023-11-23 11:19:37.154843335 +0000 UTC m=+489605.820069530: ☑️ agreed by BornChanger.

Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@BornChanger
Copy link
Contributor

/retest

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5a6c8c8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #48441   +/-   ##
================================================
  Coverage               ?   73.9189%           
================================================
  Files                  ?       1087           
  Lines                  ?     350703           
  Branches               ?          0           
================================================
  Hits                   ?     259236           
  Misses                 ?      75007           
  Partials               ?      16460           

@YuJuncen YuJuncen closed this Nov 24, 2023
@YuJuncen YuJuncen reopened this Nov 24, 2023
@YuJuncen
Copy link
Contributor

/run-cla-checker

@ti-chi-bot ti-chi-bot bot merged commit 0ad5d11 into pingcap:release-6.5 Nov 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants