-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor/brie: use the default value from flags (#48025) #48441
executor/brie: use the default value from flags (#48025) #48441
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: hillium <yujuncen@pingcap.com>
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #48441 +/- ##
================================================
Coverage ? 73.9189%
================================================
Files ? 1087
Lines ? 350703
Branches ? 0
================================================
Hits ? 259236
Misses ? 75007
Partials ? 16460 |
/run-cla-checker |
This is an automated cherry-pick of #48025
What problem does this PR solve?
Issue Number: close #48000
Problem Summary:
The current default config parameter is different from the BR CLI's. For example,
SkipStatistics
is alwaysfalse
(in BR it is defaultlytrue
),UseCheckpoint
is alwaysfalse
too (in BR it is defaultlytrue
).What is changed and how it works?
This PR exports the default config via the command line parameter of BR. And we will use it at the BRIE via SQL.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.