server,session: make sure ResultSet.Close() errors return to the client (#48447) #48484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48447
What problem does this PR solve?
Issue Number: close #48446
Problem Summary:
What is changed and how it works?
This also fix #48411 in another way, and can prevent more bugs.
Close the result set after all rs.Next(), and before cc.writeEOF()
Avoid the case that error happen and can't be sent to the client after writeEOF.
Check List
Tests
The test code in #48412 should also apply for this one, as the both can fix #48411, so I don't bother writer another duplicated test.
See #48411
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.