Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: use latest PD address to register lightning (#48687) #48690

Merged
merged 6 commits into from
Nov 18, 2023
Merged

ddl: use latest PD address to register lightning (#48687) #48690

merged 6 commits into from
Nov 18, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48687

What problem does this PR solve?

Issue Number: close #48680

Problem Summary:

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

lance6716 and others added 6 commits November 18, 2023 05:27
@lance6716 @ti-chi-bot
ddl: use latest PD address to register lightning
20b8673 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
fix lint
ee5886c 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
fix lint
be01947 
Signed-off-by: lance6716 <lance6716@gmail.com>
@Benjamin2037 @ti-chi-bot
skip mock test to get pd address.
0604143
@Benjamin2037 @ti-chi-bot
lint
8f4a636
@tangenta @ti-chi-bot
fix TestAddIndexIngestLimitOneBackend
dab77b5
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2023
Merged
13 tasks
Benjamin2037
Benjamin2037 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 18, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 18, 2023
GMHDBJD
GMHDBJD approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-18 05:36:34.99833657 +0000 UTC m=+37023.663562765: ☑️ agreed by Benjamin2037.
  • 2023-11-18 15:01:23.847492342 +0000 UTC m=+70912.512718537: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit 7181f48 into pingcap:release-7.5 Nov 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@lance6716 lance6716

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @Benjamin2037 @GMHDBJD @lance6716 @tangenta