-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/rowcodec,tablecodec: remove stmtctx
dependency from rowcodec
and tablecodec
#48816
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48816 +/- ##
================================================
+ Coverage 71.0900% 72.5583% +1.4682%
================================================
Files 1367 1391 +24
Lines 404608 412063 +7455
================================================
+ Hits 287636 298986 +11350
+ Misses 97012 94175 -2837
+ Partials 19960 18902 -1058
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #48751
Problem Summary:
Remove the dependency
stmtctx
dependency fromrowcodec
andtablecodec
.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.