statistics: do not directly update global stats when dropping a partition #48846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: hi-rustin <rustin.liu@gmail.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48846 +/- ##
=================================================
- Coverage 71.0083% 53.8932% -17.1151%
=================================================
Files 1367 1587 +220
Lines 404865 601500 +196635
=================================================
+ Hits 287488 324168 +36680
- Misses 97372 254810 +157438
- Partials 20005 22522 +2517
Flags with carried forward coverage won't be shown. Click here to find out more.
|
time-and-fate
approved these changes
Nov 23, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
hawkingrei
approved these changes
Nov 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #48182 (comment)
Problem Summary:
What changed and how does it work?
Based on this design doc, we will only update the
countandmodfiy_countfor it. Then it will use thecountandmodify_countto determine if we need to trigger an auto-analysis task.So in this PR, I dropped the update global stats operation.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.