-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix grpc client leak bug for AUTO_ID_CACHE=1 tables #48870 #48903
*: fix grpc client leak bug for AUTO_ID_CACHE=1 tables #48870 #48903
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1-20231106-v7.1.2 #48903 +/- ##
================================================================
Coverage ? 73.4352%
================================================================
Files ? 1206
Lines ? 377595
Branches ? 0
================================================================
Hits ? 277288
Misses ? 82617
Partials ? 17690 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@bb7133: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2a25285
into
pingcap:release-7.1-20231106-v7.1.2
What problem does this PR solve?
Cherry-pick #48870 to hotfix for 7.1.2
Issue Number: close #48869
Problem Summary:
What changed and how does it work?
Prior to this commit, each auto id allocator has it's own autoid client (a grpc connection inside), so if we have 60K tables there would be 60K tcp connections ...
After the fix, the autoid client is moved to domain so there should be only one autoid client instance. All the autoid allocator share this instance now.
Check List
Tests
See the reproduce steps in the issue.
The test check tcp connection counts, it's harder to do that in unit test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.