Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: a way to estimate parquet file size (#46984) #48908

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46984

What problem does this PR solve?

Issue Number: close #46980

Problem Summary:

What is changed and how it works?

Estimated by sampling: row data size/sampled row data size =~ row count/sampled row count.

Manual testing:
data size after conversion to row: using lightning converts the entire parquet format file to row format.
estimated data size : estimated data size by row data size/sampled row data size =~ row count/sampled row count.

source file size data size after conversion to row estimated data size size from file meta
357MB 2.02GB 2.04GB 640MB
388MB 2.19GB 2.19GB 694MB
449MB 2.52GB 2.54GB 804MB
434MB 2.43GB 2.46GB 773MB
446MB 2.49GB 2.50GB 796MB
436MB 2.43GB 2.43GB 779MB
423MB 2.39GB 2.39GB 761MB
416MB 2.35GB 2.37GB 752MB
436MB 2.43GB 2.45GB 781MB
472MB 2.64GB 2.65GB 844MB
442MB 2.47GB 2.49GB 794MB
480MB 2.69GB 2.69GB 860MB

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

zeminzhou and others added 9 commits November 27, 2023 03:52
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Co-authored-by: D3Hunter <jujj603@gmail.com>
Co-authored-by: D3Hunter <jujj603@gmail.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 27, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 27, 2023
@okJiang
Copy link
Member

okJiang commented Nov 27, 2023

/retest

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@5232881). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #48908   +/-   ##
================================================
  Coverage               ?   73.4271%           
================================================
  Files                  ?       1206           
  Lines                  ?     377732           
  Branches               ?          0           
================================================
  Hits                   ?     277358           
  Misses                 ?      82676           
  Partials               ?      17698           

Copy link

ti-chi-bot bot commented Nov 28, 2023

@zeminzhou: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang, zeminzhou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 03:53:49.541484373 +0000 UTC m=+808458.206710564: ☑️ agreed by okJiang.
  • 2023-11-28 09:20:33.121540997 +0000 UTC m=+914461.786767191: ☑️ agreed by lance6716.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 72e5323 into pingcap:release-7.1 Nov 28, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants