Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl,expression: make leak test more stable #4895

Merged
merged 4 commits into from
Oct 25, 2017
Merged

ddl,expression: make leak test more stable #4895

merged 4 commits into from
Oct 25, 2017

Conversation

tiancaiamao
Copy link
Contributor

/run-unit-test

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

winkyao
winkyao reviewed Oct 25, 2017
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2017
@zz-jason
Copy link
Member

/run-unit-test

@coocood
Copy link
Member

coocood commented Oct 25, 2017

LGTM

@XuHuaiyu
Copy link
Contributor

why this commit will be more stable?

@tiancaiamao
Copy link
Contributor Author

I move testleak.AfterTest() from each test case to SetupSuite() and TearDownSuite().
This would make the check less accurate, but easier to pass CI. @XuHuaiyu

@coocood coocood merged commit 834d51f into pingcap:master Oct 25, 2017
XuHuaiyu pushed a commit to XuHuaiyu/tidb that referenced this pull request Dec 11, 2017
@tiancaiamao @XuHuaiyu
ddl,expression: make leak test more stable (pingcap#4895)
0a67987
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 11, 2017
Merged
coocood pushed a commit that referenced this pull request Dec 11, 2017
@XuHuaiyu @coocood
*: improve performance of show variables (#5363)
19e32aa 
* show: fix variable scope error (#5291)

* *: improve performance of show variables (#5297)

* *: session variable value should not be modified when get global variable (#5317)

* fix ci

* ddl,expression: make leak test more stable (#4895)
@tiancaiamao tiancaiamao deleted the make-leak branch March 15, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @zz-jason @coocood @XuHuaiyu @winkyao