Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: Priority Queue for Auto Analyze #49018

Merged
merged 13 commits into from
Feb 18, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Nov 29, 2023

What problem does this PR solve?

Issue Number: None

Problem Summary:

What changed and how does it work?

Added design doc: Priority Queue for Auto Analyze.

Rendered

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Copy link

ti-chi-bot bot commented Nov 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2023
Copy link

tiprow bot commented Nov 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 marked this pull request as ready for review December 1, 2023 08:52
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@Rustin170506 Rustin170506 added sig/planner SIG: Planner component/statistics skip-issue-check Indicates that a PR no need to check linked issue. labels Dec 1, 2023
@hawkingrei hawkingrei self-requested a review December 1, 2023 09:09
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2023
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2023
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Merging #49018 (9cb4ae7) into master (f17ba4a) will increase coverage by 11.0588%.
Report is 683 commits behind head on master.
The diff coverage is n/a.

❗ Current head 9cb4ae7 differs from pull request most recent head 568a7f0. Consider uploading reports for the commit 568a7f0 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #49018         +/-   ##
=================================================
+ Coverage   70.9775%   82.0364%   +11.0588%     
=================================================
  Files          1368       2486       +1118     
  Lines        404391     681247     +276856     
=================================================
+ Hits         287027     558871     +271844     
- Misses        97368     101410       +4042     
- Partials      19996      20966        +970     
Flag Coverage Δ
integration 48.9301% <ø> (?)
unit 79.4263% <ø> (+8.4487%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+19.6466%) ⬆️
parser ∅ <ø> (∅)
br 72.0935% <ø> (+19.0677%) ⬆️

Copy link

ti-chi-bot bot commented Feb 17, 2024

@hi-rustin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 9cb4ae7 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Copy link

tiprow bot commented Feb 18, 2024

@hi-rustin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 568a7f0 link true /test tidb_parser_test
tiprow_fast_test 568a7f0 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rustin170506 Rustin170506 removed the request for review from chrysan February 18, 2024 09:26
Copy link

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2023-12-06 08:24:33.326020423 +0000 UTC m=+1602301.991246617: ☑️ agreed by qw4990.
  • 2024-02-18 09:46:11.191307761 +0000 UTC m=+177659.938930871: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 27276d3 into pingcap:master Feb 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/statistics lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants