-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, codec: hash join build wrong hash key for ENUM/SET value (#49031) #49056
executor, codec: hash join build wrong hash key for ENUM/SET value (#49031) #49056
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
81962ef
to
d971c1f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #49056 +/- ##
================================================
Coverage ? 72.0495%
================================================
Files ? 1401
Lines ? 407060
Branches ? 0
================================================
Hits ? 293285
Misses ? 94109
Partials ? 19666
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: winoros, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #49031
What problem does this PR solve?
Issue Number: close #48991
Problem Summary:
What changed and how does it work?
When the projection disables the ColumnEvaluator, it will eval the ENUM and parse a new ENUM. But the new ENUM value's value index will be set to 0.
But when we construct the hash value for the join key, we use the value index to seek the string value. So a wrong hash key is constructed.
This pull aims to solve the case.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.