Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: hotfix support use like to build range for new collation columns | tidb-test=pr/2256 #49191

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Dec 5, 2023

What problem does this PR solve?

Issue Number: ref #48181

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2023
@time-and-fate time-and-fate changed the title *: [DNM] prepare for hotfix *: [DNM] prepare for hotfix | tidb-test=pr/2256 Dec 5, 2023
@time-and-fate
Copy link
Member Author

/test mysql-test

Copy link

tiprow bot commented Dec 5, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-7.1-20231117-v7.1.1

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1-20231207-v7.1.2@ada6ff2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.1-20231207-v7.1.2     #49191   +/-   ##
================================================================
  Coverage                               ?   73.4412%           
================================================================
  Files                                  ?       1206           
  Lines                                  ?     377665           
  Branches                               ?          0           
================================================================
  Hits                                   ?     277362           
  Misses                                 ?      82611           
  Partials                               ?      17692           

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 5, 2023
@time-and-fate time-and-fate changed the base branch from release-7.1-20231117-v7.1.1 to release-7.1-20231207-v7.1.2 December 7, 2023 15:27
@time-and-fate
Copy link
Member Author

/test mysql-test

Copy link

tiprow bot commented Dec 7, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-7.1-20231207-v7.1.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@time-and-fate time-and-fate changed the title *: [DNM] prepare for hotfix | tidb-test=pr/2256 *: hotfix support use like to build range for new collation columns | tidb-test=pr/2256 Dec 7, 2023
@time-and-fate
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2023
Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-08 08:30:46.341433544 +0000 UTC m=+236.407153360: ☑️ agreed by tangenta.
  • 2023-12-11 13:19:03.590977414 +0000 UTC m=+275834.628204340: ☑️ agreed by winoros.

@time-and-fate
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7a9dad0 into pingcap:release-7.1-20231207-v7.1.2 Dec 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants