Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix log for statistics #49215

Merged
merged 1 commit into from
Dec 6, 2023
Merged

*: fix log for statistics #49215

merged 1 commit into from
Dec 6, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 6, 2023

What problem does this PR solve?

Issue Number: close #49216

Problem Summary:

What changed and how does it work?

statstics.logutil is initialized after the global one. so it prints the log at the stdout.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2023
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #49215 (af70796) into master (d932d90) will increase coverage by 1.0370%.
Report is 1 commits behind head on master.
The diff coverage is 18.4210%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49215        +/-   ##
================================================
+ Coverage   71.0414%   72.0784%   +1.0370%     
================================================
  Files          1368       1406        +38     
  Lines        402903     413494     +10591     
================================================
+ Hits         286228     298040     +11812     
+ Misses        96734      96625       -109     
+ Partials      19941      18829      -1112     
Flag Coverage Δ
integration 43.8463% <18.4210%> (?)
unit 71.0415% <ø> (+0.0001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3829% <ø> (-4.5858%) ⬇️

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe the problem? I don't see any explanation in ref the issue

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Copy link

ti-chi-bot bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2023
Copy link

ti-chi-bot bot commented Dec 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-06 06:23:56.185833284 +0000 UTC m=+1595064.851059482: ☑️ agreed by qw4990.
  • 2023-12-06 06:40:08.887679221 +0000 UTC m=+1596037.552905418: ☑️ agreed by zimulala.

@Rustin170506
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkg/statistics/handle/logutil/logutil.go Show resolved Hide resolved
@hawkingrei
Copy link
Member Author

/hold

@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@Rustin170506
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@Rustin170506
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@Rustin170506 Rustin170506 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Dec 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 373608f into pingcap:master Dec 6, 2023
@hawkingrei hawkingrei deleted the fix- branch December 6, 2023 09:13
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #49225.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2023
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong log output for statistics
5 participants